Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version displays of PSBT #29

Merged
merged 4 commits into from
Jun 8, 2024
Merged

Conversation

yanganto
Copy link
Contributor

@yanganto yanganto commented Jun 3, 2024

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 0.0%. Comparing base (1cc6f51) to head (4c7ceec).
Report is 12 commits behind head on master.

Current head 4c7ceec differs from pull request most recent head 2e3c1d1

Please upload reports for the commit 2e3c1d1 to get more accurate results.

Files Patch % Lines
psbt/src/lib.rs 0.0% 6 Missing ⚠️
psbt/src/data.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #29    +/-   ##
======================================
  Coverage     0.0%   0.0%            
======================================
  Files          17     18     +1     
  Lines        3031   3191   +160     
======================================
- Misses       3031   3191   +160     
Flag Coverage Δ
rust 0.0% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

psbt/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 2e3c1d1

@dr-orlovsky dr-orlovsky merged commit e649b0a into BP-WG:master Jun 8, 2024
18 checks passed
@yanganto yanganto deleted the version-checks branch June 9, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants