Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix retrieve tapret proof #30

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

crisdut
Copy link
Member

@crisdut crisdut commented Jun 20, 2024

Description

This PR intent fix retrieves TapRet Proof from PSBT proprietary.

MISC
Furthermore, it is possible to ask a question that is not directly related to PR:

How do I determine the maximum size of a strict_serialized operation?

For example, how do I know that in tapret_proof, I use U16 instead of U24?

Thanks

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 0.0%. Comparing base (2e3c1d1) to head (7758c44).
Report is 5 commits behind head on master.

Files Patch % Lines
psbt/src/csval/tapret.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##           master    #30   +/-   ##
=====================================
  Coverage     0.0%   0.0%           
=====================================
  Files          18     18           
  Lines        3191   3228   +37     
=====================================
- Misses       3191   3228   +37     
Flag Coverage Δ
rust 0.0% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7758c44

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Jun 21, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Jun 21, 2024
@dr-orlovsky
Copy link
Member

@zoedberg @nicbus do you have any idea how we got the tests passing with this bug in place?

@crisdut
Copy link
Member Author

crisdut commented Jun 21, 2024

@zoedberg @nicbus do you have any idea how we got the tests passing with this bug in place?

It's because we don't use this method on any calls. I realized this because I'm implementing the PSBT fascia export method. I have other improvements to make involving bp-std and RGB, but I need this one merged first.

PS: None of the other improvements are fixies but instead new methods.

@dr-orlovsky dr-orlovsky merged commit fa096ba into BP-WG:master Jun 24, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

2 participants