Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: p2sh address from script #37

Merged

Conversation

ghost
Copy link

@ghost ghost commented Aug 21, 2024

Reference: https://github.com/BP-WG/bp-core/blob/master/consensus/src/script.rs#L143-L148

the p2sh script length is 23, skip first 2 bytes, there remain 21 bytes, it will panic

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 36.8%. Comparing base (82a9b01) to head (ebb1209).
Report is 2 commits behind head on master.

Files Patch % Lines
invoice/src/address.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #37   +/-   ##
======================================
  Coverage    36.8%   36.8%           
======================================
  Files          24      24           
  Lines        4153    4153           
======================================
  Hits         1528    1528           
  Misses       2625    2625           
Flag Coverage Δ
rust 36.8% <0.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky self-requested a review August 22, 2024 07:03
@dr-orlovsky dr-orlovsky assigned dr-orlovsky and ghost and unassigned dr-orlovsky Aug 22, 2024
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Aug 22, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Aug 22, 2024
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ebb1209

@dr-orlovsky dr-orlovsky merged commit 9cd414b into BP-WG:master Aug 22, 2024
27 checks passed
@ghost ghost deleted the fix-p2sh-address-from-script branch August 22, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant