Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid HardenedIndex::ONE constant #39

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix invalid HardenedIndex::ONE constant #39

merged 1 commit into from
Aug 28, 2024

Conversation

dr-orlovsky
Copy link
Member

Closes #38

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Aug 28, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Aug 28, 2024
@dr-orlovsky dr-orlovsky self-assigned this Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 42.5%. Comparing base (04a7a2b) to head (e1df0fc).
Report is 2 commits behind head on master.

Files Patch % Lines
derive/src/index.rs 21.4% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #39     +/-   ##
========================================
- Coverage    42.6%   42.5%   -0.0%     
========================================
  Files          24      24             
  Lines        4233    4232      -1     
========================================
- Hits         1802    1800      -2     
- Misses       2431    2432      +1     
Flag Coverage Δ
rust 42.5% <21.4%> (-<0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zoedberg zoedberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK e1df0fc

@dr-orlovsky dr-orlovsky merged commit c3d2b8f into master Aug 28, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

XkeyParseError::NetworkMismatch error on mainnet
2 participants