Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs for Display and LowerHex improved, also support "1" version #41

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

dr-orlovsky
Copy link
Member

Found when was fixing RGB-WG/rgb#239 that we can improve here. Since this MUST not affect any existing code, I am just merging that in. CC @zoedberg @nicbus

@dr-orlovsky dr-orlovsky added documentation Improvements or additions to documentation enhancement New feature or request labels Sep 3, 2024
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Sep 3, 2024
@dr-orlovsky dr-orlovsky self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 42.6%. Comparing base (c3d2b8f) to head (98be887).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
psbt/src/data.rs 86.7% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master     #41   +/-   ##
======================================
  Coverage    42.5%   42.6%           
======================================
  Files          24      24           
  Lines        4232    4238    +6     
======================================
+ Hits         1800    1804    +4     
- Misses       2432    2434    +2     
Flag Coverage Δ
rust 42.6% <86.7%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dr-orlovsky dr-orlovsky merged commit 9da41a3 into master Sep 3, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant