Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code modifications in the 2nd round review of JOSS paper. #26

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

nbwuzhe
Copy link
Member

@nbwuzhe nbwuzhe commented Feb 19, 2024

We are collecting all possible code modifications here during the 2nd round of JOSS paper review, and will have another release once the paper is finalized.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d3d59f7) 69.10% compared to head (09fe1dd) 68.52%.

Files Patch % Lines
src/utils/utils.jl 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
- Coverage   69.10%   68.52%   -0.58%     
==========================================
  Files           4        4              
  Lines         356      359       +3     
==========================================
  Hits          246      246              
- Misses        110      113       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexjaffray
Copy link
Collaborator

@nbwuzhe also need to include the fix in plot_reconstruction

@nbwuzhe
Copy link
Member Author

nbwuzhe commented Feb 19, 2024

@nbwuzhe also need to include the fix in plot_reconstruction

The signature of plot_reconstruction is correct. Just the script has an scrubbed argument when calling it, which has been fixed in the same commit.

@alexjaffray
Copy link
Collaborator

@nbwuzhe I missed that, but it makes sense now. Thanks for fixing those issues and thanks @felixhorger for bringing them up to us

@alexjaffray alexjaffray self-requested a review February 19, 2024 20:34
@alexjaffray alexjaffray merged commit 5fec490 into main Feb 19, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants