region color #153
Merged
region color #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drossberg
reviewed
Aug 7, 2024
src/conv/k-g/region_list.cpp
Outdated
| for (size_t i = 0; i < names.size(); i++) { | ||
| mk_addmember(names[i].c_str(), &(geometry_head.l), NULL, WMOP_UNION); | ||
| mk_addmember(names[i].c_str(), &(all_head.l), NULL, WMOP_UNION); | ||
| } | ||
| mk_lfcomb(wdbp, geometry.getBaseName(), &geometry_head, 0); | ||
|
|
||
| mk_comb(wdbp, geometry.getBaseName(), &geometry_head.l, 1, (char*)NULL, (char*)NULL, rgb, ID_COMBINATION, 0, 0, 0, 0, 0, 0); |
There was a problem hiding this comment.
- Is this
(char*)cast really necessary? - The id or region_id is usually a unique number of a region, and not related to ID_COMBINATION. The "default" would be an increasing integer.
- Why not
mk_lcomb()?
There was a problem hiding this comment.
checking and will update.
drossberg
reviewed
Aug 8, 2024
src/conv/k-g/region_list.cpp
Outdated
| mk_lfcomb(wdbp, geometry.getBaseName(), &geometry_head, 0); | ||
|
|
||
| mk_lcomb(wdbp, geometry.getBaseName(), &geometry_head, 1, NULL, NULL, rgb, region_id); | ||
| ++region_id; |
There was a problem hiding this comment.
One more (new) thing 😈: Please, start the region IDs with 1. You can do this by writing ++region_id inside the mk_lcomb: mk_lcomb(wdbp, geometry.getBaseName(), &geometry_head, 1, NULL, NULL, rgb, ++region_id);
There was a problem hiding this comment.
sure, will update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of random coloring for the regions