-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for opaque token #310
base: main
Are you sure you want to change the base?
Conversation
Warning Rate Limit Exceeded@csikb has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 42 minutes and 37 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent updates focus on strengthening security by transitioning from basic authentication to OAuth2 and OpenID Connect across various components. This includes Docker configuration updates, integration of OAuth2 in test environments, and security enhancements in the web server. Additionally, there are refinements in Prometheus metrics setup and removal of outdated Kotlin dependencies. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
class BssFeignConfig constructor() { | ||
init { | ||
println("BssFeignConfig") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace println
with a logging framework to avoid cluttering the console output and to provide more flexible logging capabilities.
- println("BssFeignConfig")
+ logger.info("BssFeignConfig initialized")
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
class BssFeignConfig constructor() { | |
init { | |
println("BssFeignConfig") | |
} | |
class BssFeignConfig constructor() { | |
init { | |
logger.info("BssFeignConfig initialized") | |
} |
class DefaultFeignConfig { | ||
// @Bean | ||
// fun interceptor(oauth: OAuth2AccessTokenInterceptor) = oauth |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Complete the implementation of OAuth2AccessTokenInterceptor
to ensure proper authentication handling.
- // @Bean
- // fun interceptor(oauth: OAuth2AccessTokenInterceptor) = oauth
+ @Bean
+ fun interceptor(oauth: OAuth2AccessTokenInterceptor) = oauth
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
class DefaultFeignConfig { | |
// @Bean | |
// fun interceptor(oauth: OAuth2AccessTokenInterceptor) = oauth | |
class DefaultFeignConfig { | |
@Bean | |
fun interceptor(oauth: OAuth2AccessTokenInterceptor) = oauth |
Quality Gate passedIssues Measures |
No description provided.