Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added wgmlst_chewbbaca report and results markdowns #255

Merged
merged 5 commits into from
Apr 25, 2024

Conversation

svarona
Copy link
Member

@svarona svarona commented Apr 25, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

Realted to issue BU-ISCIII/BU-ISCIII#50

@Daniel-VM Daniel-VM self-requested a review April 25, 2024 13:38
Daniel-VM
Daniel-VM previously approved these changes Apr 25, 2024
Copy link
Member

@Daniel-VM Daniel-VM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍🏾
Just do the comments above and you are ready

@saramonzon saramonzon merged commit 570a930 into BU-ISCIII:develop Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants