Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving issues part 1 #262

Merged
merged 42 commits into from
Apr 29, 2024
Merged

Solving issues part 1 #262

merged 42 commits into from
Apr 29, 2024

Conversation

luissian
Copy link
Member

@luissian luissian commented Apr 16, 2024

Many files were incorrect litin, most probably because of using a old version of "black" package,

Solving issues :
#78 Allow to search services by service type
#158 Unable to convert barcode count to integer
#180 when deleting run , pool and library_preparations are also deleted
#250 AttributeError when no username is found in wetlab project
#261 Confirmation email after resolution: wrong text and email
#263 STATUS_CHOICES is deprecated from version higher than 3.1.x
#264 User can't search service/project by sample name
#265 Service state are not in the right order on first_install_tables.json

@luissian luissian linked an issue Apr 18, 2024 that may be closed by this pull request
@luissian luissian linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link
Member

@saramonzon saramonzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mira a ver porque veo algunos commits míos en tu PR, algo ha pasado con el push -f o algo

README.md Outdated Show resolved Hide resolved
LEAME.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
conf/first_install_tables.json Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
drylab/templates/drylab/search_service.html Show resolved Hide resolved
wetlab/templates/wetlab/create_new_run.html Show resolved Hide resolved
wetlab/models.py Outdated Show resolved Hide resolved
@luissian
Copy link
Member Author

Mira a ver porque veo algunos commits míos en tu PR, algo ha pasado con el push -f o algo

Yo creo que fue al estropearlo haciendo el commit en medio del rebase

@saramonzon
Copy link
Member

Me acaba de llegar sms de este último commit, solo por asegurar, tiene que ser relación 1-n no many-to-many, osea sería una foreign key en la tabla runProcess no?

@luissian luissian linked an issue Apr 24, 2024 that may be closed by this pull request
saramonzon
saramonzon previously approved these changes Apr 29, 2024
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deja este script, que habíamos dicho que lo dejábamos de momento hasta la versión 4.0 que revisemos

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

restaurado el script de migracion

@saramonzon
Copy link
Member

Perfe, lo has probado todo no? Instalando desde 0 y que funcionen las búsquedas y todo?
Si es así puedes dejar ese script en el comentario que te he puesto y rebasear :)

@luissian luissian merged commit a17e046 into BU-ISCIII:develop Apr 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment