-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the users to disable optional dependencies #1074
Conversation
Thumb up for this feature. Great! |
The nice thing about not having too many build options is that building Caffe is a guarantee that you can run all the examples and any Caffe-based code that others may share with you. Having said that, I see no harm in having non-default options that disable unneeded functionality. Furthermore, we already need this capability for cuDNN, and we'll need it again for #1020, so it's a good idea to do it now in a uniform way. How should Travis handle these different build options? I don't know what the limits on a build matrix are, but it seems we don't want our testing to be exponential in the number of options. Should we just turn on all options for testing? Is there a reason for using |
Agreed that default should be to include everything for interoperability but non-default switches are helpful and should be standardized. I'm ok with Travis checking the current build matrix of make / cmake and gpu / cpu-only. The rest are custom builds to me. I'd vote for |
It doesn't matter whether to use |
Closing since the dev branch is deprecated. Please send PRs to master. See also #2523. |
OpenCV has a lot of options for the optional libraries. Some of the newly added dependencies of Caffe are not needed by all the users and should be made optional during the building process.
This PR adds make and CMake flags and guarding macros for those components. They are especially useful for a lean deployment. But they are still enabled by default to keep the building behavior consistent.