Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

im2col with hole #3232

Closed
wants to merge 10 commits into from
Closed

im2col with hole #3232

wants to merge 10 commits into from

Conversation

tamakoji
Copy link

Ported algorithm of George Papandreou(DeepLab)' im2col with hole to fit on current caffe
implementation. variable name "hole" been modified to 'kernel_stride" which make more sense than
hole, since hole = 1 does not have hole, its just kernel stride.
modified test_im2col_kernel.cu and verified(tested test_im2col_kernel and test_im2col_layer).

@tamakoji tamakoji changed the title m2col with hole im2col with hole Oct 21, 2015
@seanbell
Copy link

👍

longjon and others added 7 commits November 4, 2015 23:58
__CUDA_ARCH__ is not defined in host code; the #if was vacuous and
misleading.
Remove dead preprocessor code for number of CUDA threads
[build] Display and store cuDNN version numbers for CMake
don't divide by 0 duration when downloading model binary
Remove hamming_distance and popcount
@llllaaaa
Copy link

llllaaaa commented Dec 4, 2015

@tamakoji Would you please rebase this PR with the current caffe?

Tamaki Kojima added 2 commits December 3, 2015 18:49
Conflicts:
	include/caffe/vision_layers.hpp
@tamakoji
Copy link
Author

tamakoji commented Dec 4, 2015

@llllaaaa done.

@llllaaaa
Copy link

llllaaaa commented Dec 4, 2015

@tamakoji Thanks a lot!

@shelhamer Could you merge this into the master branch? I think it is a very useful feature

@tamakoji
Copy link
Author

tamakoji commented Dec 4, 2015

there are lots of lint errors(mostly exceeding 80chars), do I need to fix them?

@guanyingc
Copy link

@tamakoji Thank you for your works, but the code cannot run in the cudnn mode. What should I do to make the code support cudnn?

@llllaaaa
Copy link

llllaaaa commented Dec 7, 2015

@GoYchen cudnn does not use im2col, and does not support holes

@guanyingc
Copy link

@llllaaaa Thank you very much for your answer.

@longjon
Copy link
Contributor

longjon commented Dec 29, 2015

This functionality is now provided by #3452.

Thanks @tamakoji for sharing this implementation!

@longjon longjon closed this Dec 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants