Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy proto definition to distribute directory #3587

Merged
merged 1 commit into from
Jan 30, 2016

Conversation

junshi15
Copy link

To ensure Caffe to be executable on JVM, caffe.proto is required by JVM layers to access solver and network configurations. For that purpose, we make caffe.proto available in distribute directory.

@shelhamer shelhamer changed the title Copy prototxt to distribute directory Copy proto definition to distribute directory Jan 22, 2016
@shelhamer
Copy link
Member

It's slightly odd to copy the caffe.proto source for distribution. Are you compiling the proto definition for java separately or do you have different bindings than those generated by the usual protoc? The java protobuf compilation could be added to the build.

On the other hand shipping caffe.proto seems harmless.

@junshi15
Copy link
Author

Yes, we process the proto files in java as well, mainly for the input data layer. For example, we get the source location from the memory data layer. The location is typically an HDFS URI and is the base for a Spark RDD.

@anfeng
Copy link

anfeng commented Jan 25, 2016

@shelhamer In our use case, we need Java class generated from caffe.proto at this point. Python binding may be needed later. It is okay for us if Caffe distribute those bindings for caffe.proto. However, it will be easier to let users handle them directly.

shelhamer added a commit that referenced this pull request Jan 30, 2016
Include proto definition in distribute dir
@shelhamer shelhamer merged commit 2ef5847 into BVLC:master Jan 30, 2016
@shelhamer
Copy link
Member

Ok this is fine, but to quote my earlier comment:

The java protobuf compilation could be added to the build

in the same way the Python proto bindings are built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants