Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis of identify flag #15

Merged
merged 6 commits into from
Feb 20, 2019
Merged

Analysis of identify flag #15

merged 6 commits into from
Feb 20, 2019

Conversation

tainn
Copy link
Contributor

@tainn tainn commented Feb 15, 2019

No description provided.

@tainn
Copy link
Contributor Author

tainn commented Feb 15, 2019

Typo-fixing patch pushed.

allejo
allejo approved these changes Feb 16, 2019
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestions for wording but the content LGTM 👍

_documentation/user/flags/identify.md Outdated Show resolved Hide resolved
_documentation/user/flags/identify.md Outdated Show resolved Hide resolved
_documentation/user/flags/identify.md Outdated Show resolved Hide resolved
@allejo allejo added the needs review A PR is currently being reviewed or needs to be reviewed label Feb 16, 2019
@allejo allejo mentioned this pull request Feb 16, 2019
Closed
41 tasks
@tainn
Copy link
Contributor Author

tainn commented Feb 16, 2019

Thank you for your feedback, @allejo; changes pushed accordingly.

jwmelto
jwmelto approved these changes Feb 17, 2019
View reviewed changes
_documentation/user/flags/identify.md Outdated Show resolved Hide resolved
@tainn
Copy link
Contributor Author

tainn commented Feb 18, 2019

The sentence formation might be slightly complex, but content changes pushed.

allejo
allejo requested changes Feb 19, 2019
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know my suggestion is rather vague, but I don't think there should be too much detail in this intro.

_documentation/user/flags/identify.md Outdated Show resolved Hide resolved
@allejo allejo added ready for merge Considered "ready" to be merged; allowing time before merge if anyone wants to jump in and removed needs review A PR is currently being reviewed or needs to be reviewed labels Feb 20, 2019
@allejo allejo merged commit 029c13c into BZFlag-Dev:redesign Feb 20, 2019
@allejo
Copy link
Member

allejo commented Feb 20, 2019

As always, thanks for your contribution and bearing with us to get this merged ❤️

@allejo allejo added the documentation Relating to the documentation section of the site label Feb 24, 2019
@tainn tainn deleted the identify branch February 26, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo approved these changes

@jwmelto jwmelto jwmelto approved these changes

@blast007 blast007 Awaiting requested review from blast007

Assignees
No one assigned
Labels
documentation Relating to the documentation section of the site ready for merge Considered "ready" to be merged; allowing time before merge if anyone wants to jump in
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tainn @allejo @jwmelto