Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analysis of seer flag #7

Merged
merged 2 commits into from
Feb 10, 2019
Merged

Analysis of seer flag #7

merged 2 commits into from
Feb 10, 2019

Conversation

tainn
Copy link
Contributor

@tainn tainn commented Jan 31, 2019

No description provided.

allejo
allejo previously requested changes Feb 1, 2019
View reviewed changes
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd avoid mentioning any hard limits about flag counts this flag nullifies. But overall, I really like this!

_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
@allejo allejo added the needs review A PR is currently being reviewed or needs to be reviewed label Feb 1, 2019
jwmelto
jwmelto previously approved these changes Feb 1, 2019
View reviewed changes
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
_documentation/user/flags/seer.md Outdated Show resolved Hide resolved
@allejo allejo mentioned this pull request Feb 2, 2019
Closed
41 tasks
@allejo allejo added in progress A PR currently waiting for more work to be done granted ownership A PR where project maintainers have been asked to take ownership needs review A PR is currently being reviewed or needs to be reviewed and removed needs review A PR is currently being reviewed or needs to be reviewed in progress A PR currently waiting for more work to be done labels Feb 2, 2019
@allejo allejo dismissed stale reviews from jwmelto and themself February 6, 2019 08:05

Doc has changed heavily since last review

@allejo allejo requested a review from jwmelto February 6, 2019 08:06
@allejo
Copy link
Member

allejo commented Feb 6, 2019

Thank you very much, @tainn1 for these docs! 🎉 I've gone ahead applied the feedback we had on top of your work.

Can I get another pair of eyes to look at this revised doc?

@allejo allejo merged commit a52e359 into BZFlag-Dev:redesign Feb 10, 2019
@allejo allejo removed the needs review A PR is currently being reviewed or needs to be reviewed label Feb 10, 2019
@allejo allejo added the documentation Relating to the documentation section of the site label Feb 24, 2019
@tainn tainn deleted the seer branch February 26, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allejo allejo allejo left review comments

@blast007 blast007 Awaiting requested review from blast007

@jwmelto jwmelto Awaiting requested review from jwmelto

Assignees
No one assigned
Labels
documentation Relating to the documentation section of the site granted ownership A PR where project maintainers have been asked to take ownership
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tainn @allejo @jwmelto