Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis of ricochet flag #9

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Analysis of ricochet flag #9

merged 4 commits into from
Feb 14, 2019

Conversation

tainn
Copy link
Contributor

@tainn tainn commented Feb 9, 2019

No description provided.

@Zehra
Copy link
Contributor

Zehra commented Feb 9, 2019

I'm not sure, but personally, I'd revise the following sections:

A lot of maps utilize the +r attribute in their config file to already allow the effect of Ricochet without the tanks being required to hold the specific flag for it.

It may be better simply note that the ricochet option may be enabled, since technically, the option could be set via the command line, within the map itself or within a configuration file.

..."behind which a person can hide from direct fire from the opponent, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent."

This area is sort of unclear, as it may imply that it is possible to play as a 'person' within the game itself.

@tainn
Copy link
Contributor Author

tainn commented Feb 9, 2019

Both are valid arguments; changes applied, thanks for the heads-up, @Zehra!

@allejo allejo added the needs review A PR is currently being reviewed or needs to be reviewed label Feb 9, 2019
Copy link
Member

@allejo allejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 just some minor grammar nitpicks


## Tactics

Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct fire from the opponent, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct fire from the opponent, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.
Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct enemy fire, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.

The two "from"s sound repetitive to me


Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct fire from the opponent, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.

Efficiently utilizing the Ricochet flag requires a high amount of estimating of the bullet's trajectory by planning the path before the shot, usually through the use of radar. Complexity behind the estimation increases with each additional bounce required to reach the target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Efficiently utilizing the Ricochet flag requires a high amount of estimating of the bullet's trajectory by planning the path before the shot, usually through the use of radar. Complexity behind the estimation increases with each additional bounce required to reach the target.
Efficiently utilizing the Ricochet flag requires a high amount of estimating the bullet's trajectory by planning the path before it is shot, usually through the use of radar. Complexity behind the estimation increases with each additional bounce required to reach the target.

something sounded off. thoughts on this?

@allejo allejo mentioned this pull request Feb 10, 2019
41 tasks
@tainn
Copy link
Contributor Author

tainn commented Feb 11, 2019

Both applied; thank you, @allejo!

@@ -5,4 +5,12 @@ type: Good
summary: Shots bounce off walls. Don't shoot yourself!
---

...
The Ricochet (R) flag allows the player to fire shots that can bounce off of the objects they hit. The direction of the bounce is determined by the angle under which the platform is hit. An exception are objects with the attributes `shootthrough` or `passable`, where the result is the bullet passing through the object.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The direction of the bounce is determined by the angle under which the platform is hit.

This is awkward. What platform and why am I hitting under it? I think you may be trying to allude to the Law of Reflection but it's not clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwmelto valid point; will elaborate. Any concrete suggestions beforehand?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, besides being somewhat obvious basic physics, "the angle of reflection is equal to the angle of incidence" comes to mind.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was asking for a concrete example here to avoid potential further displeasure in the wording, as we are basically thinking of the same thing just the wording was off.

Will use your suggestion.

...
The Ricochet (R) flag allows the player to fire shots that can bounce off of the objects they hit. The direction of the bounce is determined by the angle under which the platform is hit. An exception are objects with the attributes `shootthrough` or `passable`, where the result is the bullet passing through the object.

A lot of maps utilize the default ricochet option to already allow the effect of Ricochet without the tanks being required to hold the specific flag for it. The Ricochet flag holds meaning and effect on maps that do not utilize said option.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's just an evolving pet peeve, but "a lot of maps" is irrelevant to the description of the flag.

Suggested change
A lot of maps utilize the default ricochet option to already allow the effect of Ricochet without the tanks being required to hold the specific flag for it. The Ricochet flag holds meaning and effect on maps that do not utilize said option.
The Ricochet flag has no value on maps that enable ricochet. For maps where ricochet is not enabled, the Ricochet flag offers the holder the advantage of banking shots.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwmelto agreed, will change.


## Tactics

Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct enemy fire, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct enemy fire, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.
Ricochet is potent on maps filled with objects behind which a tank can hide from direct enemy fire, while attempting to shoot the opponent by bouncing shots off objects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwmelto can you elaborate as to why you removed the mention of boxes? They are notable for having straight walls, allowing for commonly 'useful' ricochet, contrary to most pyramids. Note that this is the Tactics section.

Otherwise good change suggestion.

Copy link
Member

@jwmelto jwmelto Feb 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ricochet is feasible and useful on maps with pyramids also. In fact, one can use ricochet off the angular side of a pyramid to hit a tank above you. I just didn't seen a need to limit the discussion to boxes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is true; will change.


Ricochet is potent on maps filled with objects, usually boxes, behind which a tank can hide from direct enemy fire, all while attempting to shoot them down by using the objects as proxies off of which own bullets bounce in hopes of hitting the opponent.

Efficiently utilizing the Ricochet flag requires a high amount of estimating the bullet's trajectory by planning the path before it is shot, usually through the use of radar. Complexity behind the estimation increases with each additional bounce required to reach the target.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Efficiently" is borderline subjective. Consider a more declarative style

Suggested change
Efficiently utilizing the Ricochet flag requires a high amount of estimating the bullet's trajectory by planning the path before it is shot, usually through the use of radar. Complexity behind the estimation increases with each additional bounce required to reach the target.
Effective use of the Ricochet flag requires accurate estimation of the path of a shot after it bounces off an obstacle. Multiple bounces compounds the difficulty. One may observe the trajectory of a shot and adjust the point of aim to increase accuracy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwmelto agreed, will change.

@tainn
Copy link
Contributor Author

tainn commented Feb 12, 2019

The third patch has been pushed; thank you for your feedback, @jwmelto. I have included all of the suggestions while removing the sentence about the angle of the bounce, as the summary is concluded without it as well.

@allejo allejo added ready for merge Considered "ready" to be merged; allowing time before merge if anyone wants to jump in and removed needs review A PR is currently being reviewed or needs to be reviewed labels Feb 13, 2019
@allejo allejo merged commit 5458c19 into BZFlag-Dev:redesign Feb 14, 2019
@allejo allejo added the documentation Relating to the documentation section of the site label Feb 24, 2019
@tainn tainn deleted the ricochet branch February 26, 2019 20:48
@tainn tainn restored the ricochet branch February 26, 2019 20:48
@tainn tainn deleted the ricochet branch February 26, 2019 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to the documentation section of the site ready for merge Considered "ready" to be merged; allowing time before merge if anyone wants to jump in
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants