Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add createRadialGradient to ICanvas #12976

Merged
merged 1 commit into from Sep 13, 2022

Conversation

yuripourre
Copy link
Contributor

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

@azure-pipelines
Copy link

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12976/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will let @sebavan merge.

@sebavan
Copy link
Member

sebavan commented Sep 13, 2022

I guess this should only be done if we intent to support it as well on Native otherwise ppl should cast in the web to HTMLElement Canvas.

@bghgary, @CedricGuillemet is it something we can easily add in Native ?

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking the merge until we get some info from the native team.

@CedricGuillemet
Copy link
Contributor

It's partially supported : https://github.com/memononen/nanovg/blob/397f3300bc14bdb856ec429c71c345ab0340b0a6/src/nanovg.h#L414

with native x0,y0 and x1,y1 must be same value.

@sebavan
Copy link
Member

sebavan commented Sep 13, 2022

It's partially supported : https://github.com/memononen/nanovg/blob/397f3300bc14bdb856ec429c71c345ab0340b0a6/src/nanovg.h#L414

with native x0,y0 and x1,y1 must be same value.

So it does make sense to merge this one ?

@sebavan
Copy link
Member

sebavan commented Sep 13, 2022

Mainly wondering as it could create discrepancies between the two ?

@CedricGuillemet
Copy link
Contributor

Mainly wondering as it could create discrepancies between the two ?

There are already discrepancies between native and Web. Like drawImage is partially supported and some modes will render nothing or incorrectly. We don't have a lot of traction for Native GUI atm. So, if this PR is mandatory for future dev, merge it.

@sebavan sebavan merged commit a56a6c3 into BabylonJS:master Sep 13, 2022
@yuripourre yuripourre deleted the add-createRadialGradient branch September 13, 2022 13:57
RaananW pushed a commit that referenced this pull request Dec 9, 2022
Add createRadialGradient to ICanvas

Former-commit-id: 6976bceac68d2aff376d8428da0a6efb5d35b7ff
@yuripourre yuripourre restored the add-createRadialGradient branch November 21, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants