-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add createRadialGradient to ICanvas #12976
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/12976/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/12976/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/12976/merge#BCU1XR#0 |
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will let @sebavan merge.
I guess this should only be done if we intent to support it as well on Native otherwise ppl should cast in the web to HTMLElement Canvas. @bghgary, @CedricGuillemet is it something we can easily add in Native ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking the merge until we get some info from the native team.
It's partially supported : https://github.com/memononen/nanovg/blob/397f3300bc14bdb856ec429c71c345ab0340b0a6/src/nanovg.h#L414 with native x0,y0 and x1,y1 must be same value. |
So it does make sense to merge this one ? |
Mainly wondering as it could create discrepancies between the two ? |
There are already discrepancies between native and Web. Like drawImage is partially supported and some modes will render nothing or incorrectly. We don't have a lot of traction for Native GUI atm. So, if this PR is mandatory for future dev, merge it. |
Add createRadialGradient to ICanvas Former-commit-id: 6976bceac68d2aff376d8428da0a6efb5d35b7ff
Description borrowed from: https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/createRadialGradient