Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GamepadManager: Fixed issue where providing scene object to constructor would prevent status updates #13798

Merged
merged 1 commit into from
May 3, 2023

Conversation

PolygonalSun
Copy link
Contributor

A user on the forum found an issue where the GamepadManager wouldn't update its gamepad statuses when this._scene was defined. The fix was to remove these checks. Thanks to user CiderPunk for finding this issue.

Forum Link: https://forum.babylonjs.com/t/gamepad-events-not-triggering/40362

@bjsplat
Copy link
Collaborator

bjsplat commented May 3, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented May 3, 2023

@PolygonalSun PolygonalSun marked this pull request as ready for review May 3, 2023 16:22
Copy link
Member

@RaananW RaananW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reasoning behind checking if the scene existed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants