-
Notifications
You must be signed in to change notification settings - Fork 133
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove Android xr double render (#1297)
This code has been in the Android XR implementation forever, and was never understood. It did an explicit eglSwapBuffers to present to the screen, which was needed in Babylon React Native as somehow the bgfx rendering path was different between the two. Now, even in BRN this results in double rendering. Maybe this is a result of one of the bgfx updates. Since it seems to no longer be needed in any scenario, this PR removes it. Unfortunately XR on Android in the BN Playground is broken in a different way currently, so I have not been able to verify this works correctly in that scenario. But previously this code was incorrect in BN anyway, so I expect this is correct now in both BN and BRN.
- Loading branch information
Showing
3 changed files
with
2 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters