Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog post background flashing #99

Open
louh opened this issue Jan 23, 2022 · 3 comments
Open

Blog post background flashing #99

louh opened this issue Jan 23, 2022 · 3 comments

Comments

@louh
Copy link
Member

louh commented Jan 23, 2022

Here's the problem -

setInterval(this.tick, 3000);

Fix would be to make a subcomponent for the reading time that manages timer state by itself, rather than at the page template level where it causes the entire page to re-render.

@maboa
Copy link
Member

maboa commented Jun 6, 2022

Suggest we disable in the meantime?

maboa added a commit that referenced this issue Jun 6, 2022
There are more in depth fixes but in the short term this flash is a liability for anybody prone to seizures.

This disables our constantly updating reading time, but that's OK since it was causing harm.

We'll make a longer term fix that restores the functionality at a later date.

Related to Issue #99
@maboa
Copy link
Member

maboa commented Jun 6, 2022

Addressed by #108

@maboa maboa closed this as completed Jun 6, 2022
@maboa
Copy link
Member

maboa commented Jun 6, 2022

Opening again because useful info here for actually fixing the problem.

@maboa maboa reopened this Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants