Badger registry 2.0 #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n now be promted to "deprecated"
okjintao
reviewed
Mar 16, 2022
contracts/BadgerRegistry.sol
Outdated
| //@dev Anyone can add a vault to here, it will be indexed by their address | ||
| function add(string memory version, address vault) public { | ||
| function add( | ||
| string memory version, |
There was a problem hiding this comment.
not sure its covered in the spec although it would be nice to have guards here for input validation wrt version and allow some kind of management on release versions available to ensure proper usage of functionality
There was a problem hiding this comment.
Yes makes a lot of sense. I've added a VersionGuard modifier with requires a supported version. To ensure that checking the version has O(1) compatibility I used an Bytes32Set for storing the versions using Keccak256 hash for this.
…en checking if a version is supported
|
Closed in favour of #12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting this pull request to implement the new Badger Dao registry. I've done the following steps to fulfill the task:
Implemented a role-based access control based on the requirements. Now there are 3 roles used within the contract:
To protect functions from being accessed by unauthorized users I've created two modifiers
Added Metadata to vaults. The function "add" now accepts a new parameter "metadata" of type string. Which can be used to store arbitrary strings as metadata of a certain vault.
Modified the return values of "getVaults" and "getFilteredProductionVaults". They are now returning an array that contains two arrays "vaultAddresses" and "vaultMetadata"
Modified the struct "VaultData". It has now a new field called metadata that is used to store the vaults metadata.
Modified the function "set" and "deleteKey" so they are now using to mappings "keys" and "addresses" to storge the needed values in both ways. Also renamed function names from "set" to "addKey" and events from "Set" to "KeyAdded".
Replaced "initialized" function with a constructor.
There is still an ongoing question regarding the "devote" function. I think this function can be removed since the process of devotion is now replaced by promoting to "deprecated".
If any further features could make sense to build please let me know I would love to build them!
If there are any questions left please feel free to reach me out
Discord : Alex245#0896