#49: Instead of 'latest' show the actual version being installed #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
diff is too noisy - I cant see what is changing. Maybe do an entire codebase reformat commit first? Invoke-DbatoolsFormatter with dataplat/dbatools#5790 makes it quite easy to do. |
Badgerati
commented
Jun 20, 2019
| # if the version is latest, attempt to get the real current version | ||
| if (Test-VersionPassedIsLatest -Version $Version) { | ||
| $Version = Get-ChocolateyLatestVersion -Package $Package -Source $Source | ||
| } |
There was a problem hiding this comment.
This is the main change; to detect if the version is using "latest", and get the current version from chocolatey
|
I'll raise a separate issue about styling and syntax later; just to get it out of the way. The main change is the above commit comment, as well as the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49