Feat delete workspace #97
Conversation
| :loading="loading" | ||
| type="table" | ||
| /> | ||
| <v-skeleton-loader v-if="loading" :loading="loading" type="table" /> |
There was a problem hiding this comment.
Normalement tu peux mettre le contenu dans le skeleton et ne pas mettre le v-if il me semble
There was a problem hiding this comment.
Sans le v-if
…o feat-delete-workspace
…replace the Warning
| }; | ||
|
|
||
| async function listFolders() { | ||
| const folders = await Folders.find({}).populate('_parentFolder'); | ||
| return folders; | ||
| } | ||
|
|
||
| async function deleteFolderContains(folderId) { |
There was a problem hiding this comment.
please replace every 'contains' by 'content'
| @@ -22,11 +25,26 @@ async function existsByName({ workspaceName, groupId }) { | |||
| }); | |||
| } | |||
|
|
|||
| async function findWorkspace(params) { | |||
There was a problem hiding this comment.
I think we should avoid using params as parameters' names from now on and use workspace instead, as we did for the update function
To confirm with @Jessy-BAER
| return Workspaces.deleteOne({ _id: workspaceId }, async () => { | ||
| await Mailings.deleteMany({ _workspace: workspaceId }); | ||
| const foldersToDelete = await Folders.find({ _workspace: workspaceId }); | ||
| if (foldersToDelete && foldersToDelete.length > 0) { |
There was a problem hiding this comment.
if (foldersToDelete.length) might suffice here, I'm not sure though, it might be an ES6 syntaxic sugar not supported by Node
@qlereboursBS could you confirm this please
| try { | ||
| this.loading = true; | ||
| const workspacesResponse = await $axios.$get(groupsWorkspaces(params)); | ||
| this.workspaces = workspacesResponse?.items?.map((workspace) => ({ |
There was a problem hiding this comment.
I think it might be better to replace l. 63 & 64 by a spread of workspace
packages/ui/helpers/locales/en.js
Outdated
| @@ -214,5 +228,8 @@ export default { | |||
| rename: 'Rename', | |||
| transfer: 'Transfer', | |||
| }, | |||
| workspaces: { | |||
There was a problem hiding this comment.
I think you should delete this key since there's already a delete key in global
packages/ui/helpers/locales/fr.js
Outdated
| @@ -127,11 +127,23 @@ export default { | |||
| }, | |||
| }, | |||
| }, | |||
| workspace: { | |||
| checkBoxError: 'Vous devez accepter de continuer!', | |||
There was a problem hiding this comment.
This should be corrected to something like "Vous devez accepter pour continuer!"
packages/ui/helpers/locales/fr.js
Outdated
| @@ -217,5 +229,8 @@ export default { | |||
| rename: 'Renommer', | |||
| transfer: 'Transférer', | |||
| }, | |||
| workspaces: { | |||
#94