Updated instructions for Pypy on Ubuntu/Linux #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he window. So far I only implemented tiles, and that doesn't work anyway. It's also tremendously slow.
…!= x*4 bc you still have the low bits) and now it seems to work, but still really slowly, and just tiles
…ugh the Renderer is not fast enough.
…g! Still need to implement sprites, though.
…ve spent too long on embedded platforms to know that they're not better. The original math was easier to follow
…mpts failed so it probably won't get much faster without big changes.
…ose (and SDL2 has scaling now too)
…e I made earlier, sorry
… changes that shouldn't have been merged back into master)
…ot a blank screen, threw off the tests for a while)
|
I'm not sure why it lists so many commits... could I have updated my fork wrong? |
|
Hmm. I think you should have done some rebasing. But I think it is ok, if I squash and merge. |
|
That's what I get for leaving local changes on my master branch. I did a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #16
I tested and updated the installation instructions for Pypy on Ubuntu. This was done on a pristine Ubuntu 18.04 LTS VM, so the dependencies are definitely enough to get things running.
This does not involve Portable Pypy, though I did test it and found that it could not install the dependencies because it wasn't configured by default to look at the system paths. It is still likely that alternate instructions could be provided for normal (not portable) installations of Pypy 7.0, or that we could figure out how to get Portable Pypy to compile against the system libraries (though that kindof defeats the purpose of it). However, I don't notice any speed difference between Pypy 5.1 (Linux) or Pypy 7.0 (macOS host). I also think it's beyond the scope of this project. Personally, I would rather try to eliminate or make optional imageio and numpy as dependencies so there wouldn't be a need for so many system libraries (although I'm not sure if that would fix things for libsdl2-dev).
Oh, and I changed the instructions to put the virtualenv in the root PyBoy folder instead of Source, because Source was feeling a bit cluttered and putting the venv in Source named it
(Source)instead of(PyBoy)which is nicer.