feat: support multiple models on autotune service #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NOBLES5E
reviewed
Jul 7, 2021
| @@ -37,6 +37,7 @@ class BaguaHyperparameter(BaseModel): | |||
| """ | |||
|
|
|||
| buckets: List[List[TensorDeclaration]] = [] | |||
| bucket_size: int = 0 | |||
There was a problem hiding this comment.
Is this hyperparameter class only used in service?
There was a problem hiding this comment.
Yes, I put it here because this is the simplest and most intuitive way to achieve
There was a problem hiding this comment.
I mean the BaguaHyperparameter class. If it is only used in service, we can move the whole class to service module
There was a problem hiding this comment.
Got it, but not exactly, new distributed hyperparameters should also be configured here, such as is_hierarchical_reduce
NOBLES5E
reviewed
Jul 7, 2021
| @@ -1,17 +1,30 @@ | |||
| import unittest | |||
There was a problem hiding this comment.
let's include the autotune test in CI?
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
one more thing, we also need test case for different datatypes (fp16 fp32 mixed precision case) |
NOBLES5E
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.