Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: migrate "MASTER_REQUEST" to "MAIN_REQUEST" for Symfony 7 compatibility #133

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix: migrate "MASTER_REQUEST" to "MAIN_REQUEST" for Symfony 7 compatibility #133

merged 2 commits into from
Dec 5, 2023

Conversation

FluffyDiscord
Copy link
Contributor

Fixes #132 , backwards compatible up to 5.3

@Baldinof
Copy link
Owner

Baldinof commented Dec 5, 2023

Thanks, can you fix the unit test? I will handle phpstan separately

@FluffyDiscord
Copy link
Contributor Author

done

@Baldinof Baldinof merged commit ed13b63 into Baldinof:3.x Dec 5, 2023
7 of 9 checks passed
@Baldinof
Copy link
Owner

Baldinof commented Dec 5, 2023

Thank you, I released 3.0.3 with it :)

@FluffyDiscord
Copy link
Contributor Author

thanks for the quick response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined constant self::MASTER_REQUEST
2 participants
@FluffyDiscord @Baldinof