Mr 127 requiredsvvoltage #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haigutus
reviewed
Jul 29, 2024
| from emf.task_generator.task_generator import update_task_status | ||
| from emf.common.logging.custom_logger import get_elk_logging_handler | ||
|
|
||
| logger = logging.getLogger(__name__) | ||
| parse_app_properties(caller_globals=globals(), path=config.paths.cgm_worker.merger) | ||
|
|
||
|
|
||
| def set_brell_lines_to_zero_in_models(opdm_models, magic_brell_lines: dict = None, profile_to_change: str = "SSH"): |
| return first_row | ||
|
|
||
|
|
||
| def copy_topological_nodes_over(cgm_sv_data, original_data: list | pandas.DataFrame): |
There was a problem hiding this comment.
Unclear what is happening here. CN has two terminals, one has EI and other has ACLineSegment, we need dataframe with the other end voltage, eg other end TP node
| already_existing = cgm_sv_data[(cgm_sv_data['KEY'] == 'SvVoltage.TopologicalNode') & | ||
| (cgm_sv_data['VALUE'].isin(in_several_igms.index))] | ||
| # Exclude the existing nodes | ||
| in_several_igms = in_several_igms[~in_several_igms.index.isin(already_existing['VALUE'])] |
There was a problem hiding this comment.
Please do not use isin, it is known to be slow, there is function in triplet, filter data frame by data frame, if needed
|
Was intended to be illustration only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hack for #127 copy svVoltages for missing boundary nodes from igms