Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] if you reset a 2/3 scan, the "Distance to Scan #2:" field is not cleared. #32

Closed
Tracked by #39
slippycheeze opened this issue Jan 1, 2023 · 2 comments · Fixed by #33
Closed
Tracked by #39

[BUG] if you reset a 2/3 scan, the "Distance to Scan #2:" field is not cleared. #32

slippycheeze opened this issue Jan 1, 2023 · 2 comments · Fixed by #33
Assignees
@Balvald
Labels
bug Something isn't working
Milestone
v0.2.2

Comments

@slippycheeze
Copy link
Contributor

slippycheeze commented Jan 1, 2023 •
edited
Loading

Describe the bug
If you reset a scan with two out of three samples, the "Distance to Scan #2:" field remains pointed at the second sample of the old exobio item.

The "Distance to Scan #1:" field works fine, and when you take the second sample it correctly overwrites the second scan field. No functional problems, just a somewhat confusing display.

To Reproduce
Steps to reproduce the behavior:

  1. Scan any random exobio thing twice. eg: get to Tussock Vigram (2/3)
  2. Observe that Distance to Scan #1 and #2 fields are both populated.
  3. Scan any other exobio thing, accepting the "will discard the partial sample" warning.
  4. Observe that Distance to Scan #1 is your newly scanned thing, but #2 is still pointing to the previous sample.

(For maximum effect, travel to a new system between steps 2 and 3 ;)

Expected behavior
The second scan should be cleared.

Desktop (please complete the following information):

  • OS: Win 11
  • AST Version: 0.2.1
  • EDMC Version: latest. sorry, can't quickly find the version, and I don't think it matters.

Thank you so much for all your hard work.
@slippycheeze slippycheeze added the bug Something isn't working label Jan 1, 2023
@slippycheeze slippycheeze changed the title [BUG] if you reset a 2/3 scan, the "Distance to Scan #2:" field is not cleared. [BUG] if you reset a 2/3 scan, the "Distance to Scan #2:" field is not cleared. Jan 1, 2023
@slippycheeze
Copy link
Contributor Author

wish there was a better way to avoid hyperlinking as issue references, sorry for spam.

@Balvald
Copy link
Owner

Balvald commented Jan 1, 2023 •
edited
Loading

Just realised I also do not clear distances after using the manual reset button in the preferences.

@Balvald Balvald self-assigned this Jan 1, 2023
Balvald added a commit that referenced this issue Jan 1, 2023
@Balvald
Update load.py
84533a4 
fixing #32 and also reset button behaviour

doing the change I hinted at in my comment of #30
also proper rounding before value was just trunctated
though there are a few edgecases I've found that don't round properly

concerning #31 :
small fix where distance was always red if there wasn't even a position logged.
@Balvald Balvald added this to the v0.2.2 milestone Jan 2, 2023
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Update load.py
375ca80 
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
@Balvald Balvald linked a pull request Jan 2, 2023 that will close this issue
Pull state for v0.2.2 to main #33
Merged
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update load.py
495e55c 
fixing #32 and also reset button behaviour

doing the change I hinted at in my comment of #30
also proper rounding before value was just trunctated
though there are a few edgecases I've found that don't round properly

concerning #31 :
small fix where distance was always red if there wasn't even a position logged.
@Balvald Balvald closed this as completed in c6cc40a Jan 3, 2023
@Balvald Balvald mentioned this issue Jan 8, 2023
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging a pull request may close this issue.

Pull state for v0.2.2 to main Balvald/ArtemisScannerTracker
2 participants
@slippycheeze @Balvald