Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Journalcrawler should track and update notsoldbiodata.json #28

Closed
Balvald opened this issue Dec 29, 2022 · 4 comments · Fixed by #33
Closed

[Feature] Journalcrawler should track and update notsoldbiodata.json #28

Balvald opened this issue Dec 29, 2022 · 4 comments · Fixed by #33
Assignees
@Balvald
Labels
enhancement New feature or request
Milestone
v0.2.2

Comments

@Balvald
Copy link
Owner

Balvald commented Dec 29, 2022

Is your feature request related to a problem? Please describe.
From a Forum post:
I am out in the black so is there not anyway for this to scan my journals for just unsold data so I can see what I currently have is worth? I have only been out for a week so there are less than 20 journals to deal with.

Describe the solution you'd like
The journal crawler should not only update the soldbiodata.json but also the notsoldbiodata.json
@Balvald Balvald added the enhancement New feature or request label Dec 29, 2022
@Balvald Balvald self-assigned this Dec 29, 2022
@Balvald Balvald changed the title [Feature] Journal crawler should track and update notsoldbiodata.json [Feature] Journalcrawler should track and update notsoldbiodata.json Dec 29, 2022
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Implementation of #28
e3a9a44 
technically it already tracks the "not yet sold data" as "possibly sold data".

Had to add a few extra checks to both the items that got sold (had a duplication issue so that on every rescan of my journals because I changed the method from deleting the old soldbiodata.json and building it anew to updating it)

The same with the notsoldbiodata.json.
Additionally I had elements that were wrongfully added to the notsoldbiodata.json that actually were sold already.
So I needed a specific check for those.
@Balvald Balvald added this to the v0.2.2 milestone Jan 2, 2023
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Update load.py
375ca80 
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 2, 2023
@Balvald
Update Readme for v0.2.2
7b6153a 
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
@Balvald Balvald linked a pull request Jan 2, 2023 that will close this issue
Pull state for v0.2.2 to main #33
Merged
@Balvald
Copy link
Owner Author

Balvald commented Jan 2, 2023

Done for today. Will check this one again tomorrow

@Balvald
Copy link
Owner Author

Balvald commented Jan 3, 2023 •
edited
Loading

Trying to think of any pitfalls that this can run into.

Technically thers now a third way to create discrepancies which could be averted if the SellOrganics event would state system and body of the exobiology sold in the journals:

That is get the journal crawler to read through journals that end up with any set of notsoldbiodata.json.
Skip over a journal that has a resurrect event then have a "SellOrganic" event later where the code identifies that the whole batch needs to be sold.
-> is not a problem if we get a full track record of things from any point in the past to the present.
-> For now I'll be deeming the keeping a complete track of journals that does not have random missing "holes" to be used with the journal crawler sufficient to not run into this.

Gotta add this one to #11 sometime

Fixable Pitfall:
Though there is the off chance where we have two sets of journals with some overlap where notsoldbiodata gets something added in the first run, that shouldn't be there after the second set of journals are crawled.
-> Analyse event happens in the first set of journals and corresponding sell event happens in the second set.
-> needs another check where prexisting elements in the notsoldbiodata have moved to the soldbiodata side of things. in the journal crawler.

Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update journalcrawler.py
3e2cdc6 
Now also checking preexisting elements if they should stay in notsoldbiodata.json because they have already moved to soldbiodata.json.

This is the one fixable pitfall that I mentioned in a comment of #28
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Implementation of #28
df57d22 
technically it already tracks the "not yet sold data" as "possibly sold data".

Had to add a few extra checks to both the items that got sold (had a duplication issue so that on every rescan of my journals because I changed the method from deleting the old soldbiodata.json and building it anew to updating it)

The same with the notsoldbiodata.json.
Additionally I had elements that were wrongfully added to the notsoldbiodata.json that actually were sold already.
So I needed a specific check for those.
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update load.py
c6cc40a 
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line.

gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings.

increased version number v0.2.2

State on dev should now be:
Implemented:
#28 , #29, #30, #31
Fixed:
#32

Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this.

I want to do some additional testing regarding #28 before declaring this the next update.
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update Readme for v0.2.2
ea736eb 
- New picture for preferences.
- Added missing option and updated renamed buttons
- Most new featues are options or slight changes to already existing features.

Now with the readme updated
I'll tag the rest of the issues as finished once I pull everything over.

closes #31 #30 #29 #28
Balvald added a commit that referenced this issue Jan 3, 2023
@Balvald
Update journalcrawler.py
11f8fc8 
Now also checking preexisting elements if they should stay in notsoldbiodata.json because they have already moved to soldbiodata.json.

This is the one fixable pitfall that I mentioned in a comment of #28
@Balvald
Copy link
Owner Author

Balvald commented Jan 7, 2023

Looking back at this I forgot to add the tracking for the unsold value and it took two more incremental updates of just minor fixes for me to finally finish this one properly.

@Balvald Balvald reopened this Jan 7, 2023
@Balvald Balvald closed this as completed Jan 7, 2023
@Balvald
Copy link
Owner Author

Balvald commented Jan 7, 2023

Next time I could go and read it properly the first time round.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Balvald Balvald

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.2
Development

Successfully merging a pull request may close this issue.

Pull state for v0.2.2 to main Balvald/ArtemisScannerTracker
1 participant
@Balvald