Pull state for v0.2.2 to main #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forgot that we should only hide things if we sell when the option is actually set. removed commented code from the old sold and notsoldbiodata json formats
changed unsold value tracking to happen in self.rawvalue instead of AST_value that is mainly for displaying it. Added number shortening function and option to use it via tickbox in the preferences. When outside of the Clonal Colonial Range the respective entries become green to signify that a new sample can be taken. added ui_colourlabel and ui_colourentry that just add another parameter to set the text (in tk terminology foreground "fg") colour
forgot that I'm in plugin on the rawvalue is None check. resurrection also resets scan progress back to 0. added price for started sampling to the field that shows its name. new local variables that I needed anyway for this made a few lines in the Analyse case more readable. moved ui_colourlabel a few lines down.
CCR distances now in red if not in the clear for next sampling Obfustcated use of AST_value that actually just needs the raw value replaced accordingly. also rebuild ui after resurrect event since this resets the scan progress now. Not resetting any other progress as one could want to know where to go back to, to attempt again what they couldn't finish. added worth to full status
fixing #32 and also reset button behaviour doing the change I hinted at in my comment of #30 also proper rounding before value was just trunctated though there are a few edgecases I've found that don't round properly concerning #31 : small fix where distance was always red if there wasn't even a position logged.
using rawvalue instead of AST_value with cmdrstates now. compatible with old values. removed commented code. created helper function "update_last_scan_plant" to call in either the on preferences closed method or in bioscan handling. so that the shortening will also switch after the corresponding preference was changed and the preference window closed.
realized we'll have to call on preferences_closed anyway when updating AST_state. so it was moved to only being there. This was done so that AST_state will update according with the shorten values option.
technically it already tracks the "not yet sold data" as "possibly sold data". Had to add a few extra checks to both the items that got sold (had a duplication issue so that on every rescan of my journals because I changed the method from deleting the old soldbiodata.json and building it anew to updating it) The same with the notsoldbiodata.json. Additionally I had elements that were wrongfully added to the notsoldbiodata.json that actually were sold already. So I needed a specific check for those.
visually seperated the autom. hiding features from the "hide X" tickboxes by adding an additional line. gave the option that hosrtens the credits down to 4 digits a more fitting name in the settings. increased version number v0.2.2 State on dev should now be: Implemented: #28 , #29, #30, #31 Fixed: #32 Regarding #28 I thought it is important enough to always be visible along either just species or full status (as species is part of full status) so no extra hiding option needed for this. I want to do some additional testing regarding #28 before declaring this the next update.
This was
linked to
issues
Jan 2, 2023
Now also checking preexisting elements if they should stay in notsoldbiodata.json because they have already moved to soldbiodata.json. This is the one fixable pitfall that I mentioned in a comment of #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.