Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contribution #26

Merged
merged 7 commits into from
Jun 24, 2023
Merged

Contribution #26

merged 7 commits into from
Jun 24, 2023

Conversation

gimhanul
Copy link
Member

๐ŸŽซ ๊ด€๋ จ ์ด์Šˆ

close #25


๐Ÿ“„ ๊ฐœ์š”

ํ˜‘์—… ์ฒด์ œ ์ •๋น„ (ํ•œ๊ตญ์‚ฌ์ฒ˜๋Ÿผ๋งํ•˜๊ธฐ)


๐Ÿ”จ ์ž‘์—… ๋‚ด์šฉ

  • Issue Template ์ •๋น„
  • PR Template ์ •๋น„
  • CONTRIBUTING.md ์ถ”๊ฐ€
  • code review pr actions ์ถ”๊ฐ€
  • commit template ์ถ”๊ฐ€

๐Ÿ ํ™•์ธ ์‚ฌํ•ญ

  • ํ…Œ์ŠคํŠธ๋ฅผ ์™„๋ฃŒํ–ˆ๋‚˜์š”?
  • API ๋ฌธ์„œ๋ฅผ ์ž‘์„ฑํ–ˆ๋‚˜์š”?
  • ์ฝ”๋“œ ์ปจ๋ฒค์…˜์„ ์ค€์ˆ˜ํ–ˆ๋‚˜์š”?

๐Ÿ™‹๐Ÿป ๋ง๋ถ™์ผ ๋ง

@gimhanul
docs(#25): set commit convention
428ebab 
- .gitmessage ํŒŒ์ผ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
  `git commit` ๋ช…๋ น์–ด๋งŒ ์ž…๋ ฅํ•ด์„œ ํ…œํ”Œ๋ฆฟ์„ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
- CONTRIBUTING.md ํŒŒ์ผ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
@gimhanul
docs(#25): PR Template
d78eff7 
- pr template์— ๊ฐ€์ด๋“œ ์ฃผ์„์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค
- ํ•ด๋‹น ์ฃผ์„์„ ๋ณด๊ณ  ๋” ์ž์„ธํžˆ PR์„ ์ž‘์„ฑํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค
@gimhanul
docs(#25): branch naming
9da795a 
- ๋ธŒ๋žœ์น˜ ๋„ค์ด๋ฐ ๊ทœ์น™์„ ์ •๋ฆฌํ–ˆ์Šต๋‹ˆ๋‹ค.
@gimhanul
docs(#25): add Issue Template
2663e63 
- ์ด์Šˆ ํ…œํ”Œ๋ฆฟ์„ ์ „์ฒด์ ์œผ๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
- ๊ฐœ์„ ํ•˜๊ธฐ ์ด์Šˆ ํ…œํ”Œ๋ฆฟ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.
@gimhanul
docs(#25): contributing.md format
2eb118a 
- outline์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค
- ๋ณด๊ธฐ ๋„ˆ๋ฌด ๋ถˆํŽธํ•ด์„œ <br>๋กœ ๋ฌธ๋‹จ์„ ๋‚˜๋ˆด์Šต๋‹ˆ๋‹ค
@gimhanul
ci(#25): comment for supporting review on PR
21bd5de 
- PR์„ ์—ด์—ˆ์„ ๋•Œ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๋ฅผ ๋•๋Š” ๋Œ“๊ธ€์„ ๋‹ฌ๋„๋ก ํ–ˆ์Šต๋‹ˆ๋‹ค.
@gimhanul gimhanul self-assigned this Jun 24, 2023
@gimhanul gimhanul requested a review from a team as a code owner June 24, 2023 13:20
@github-actions
Copy link

์ด๋ ‡๊ฒŒ ๋ฆฌ๋ทฐํ•ด์ฃผ์„ธ์š”.

๐Ÿ–๏ธ ๊ทœ์น™

  1. ์™œ ๊ฐœ์„ ์ด ํ•„์š”ํ•œ์ง€ ์ถฉ๋ถ„ํžˆ ์„ค๋ช…ํ•ด์ฃผ์„ธ์š”.
  2. ๋‹ต์„ ์•Œ๋ ค์ฃผ๊ธฐ๋ณด๋‹ค๋Š” ์Šค์Šค๋กœ ๊ณ ๋ฏผํ•˜๊ณ  ๊ฐœ์„  ๋ฐฉ๋ฒ•์„ ์„ ํƒํ•  ์ˆ˜ ์žˆ๊ฒŒ ํ•ด์ฃผ์„ธ์š”.
  3. ์ฝ”๋“œ๋ฅผ ๊น”๋”ํ•˜๊ฒŒ ์œ ์ง€ํ•˜๊ณ , ์ผ๊ด€๋˜๊ฒŒ ๊ตฌํ˜„ํ•˜๋„๋ก ์•ˆ๋‚ดํ•ด ์ฃผ์„ธ์š”.
  4. ๋ฆฌ๋ทฐ ๊ณผ์ •์ด ์ˆ™์ œ๊ฒ€์‚ฌ๊ฐ€ ์•„๋‹Œ ํ•™์Šต๊ณผ์ •์œผ๋กœ ๋Š๋‚„ ์ˆ˜ ์žˆ๊ฒŒ ๋ฆฌ๋ทฐํ•ด ์ฃผ์„ธ์š”.
  5. ๋ฆฌ๋ทฐ๋ฅผ ์œ„ํ•œ ๋ฆฌ๋ทฐ๋ฅผ ํ•˜์ง€ ๋งˆ์„ธ์š”. ํ”ผ๋“œ๋ฐฑ ํ•  ๊ฒŒ ์—†์œผ๋ฉด ์นญ์ฐฌํ•ด ์ฃผ์„ธ์š”.

๐Ÿฅฌ ์šฐ์„ ์ˆœ์œ„

๋ฆฌ๋ทฐ ์ค‘์š”๋„์— ๋”ฐ๋ผ ๋‹ค์Œ๊ณผ ๊ฐ™์€ prefix๋ฅผ ๋ถ™์—ฌ์ฃผ์„ธ์š”.

์˜ˆ์‹œ | (P5) ์“ธ๋ชจ์—†๋Š” ์ฃผ์„ ์‚ญ์ œํ•ด์ฃผ์„ธ์š”.

  • P1: ๊ผญ ๋ฐ˜์˜ํ•ด์ฃผ์„ธ์š” (Request changes)
  • P2: ์ ๊ทน์ ์œผ๋กœ ๊ณ ๋ คํ•ด์ฃผ์„ธ์š” (Request changes)
  • P3: ์›ฌ๋งŒํ•˜๋ฉด ๋ฐ˜์˜ํ•ด ์ฃผ์„ธ์š” (Comment)
  • P4: ๋ฐ˜์˜ํ•ด๋„ ์ข‹๊ณ  ๋„˜์–ด๊ฐ€๋„ ์ข‹์Šต๋‹ˆ๋‹ค (Approve)
  • P5: ๊ทธ๋ƒฅ ์‚ฌ์†Œํ•œ ์˜๊ฒฌ์ž…๋‹ˆ๋‹ค (Approve)

@gimhanul
docs(#25): typo
8b2addd 
- ์˜คํƒ€๋ฅผ ๊ณ ์ณค์Šต๋‹ˆ๋‹ค
- ํฌ๋งท์„ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค
@sonarcloud
Copy link

sonarcloud bot commented Jun 24, 2023

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@gimhanul gimhanul merged commit 525de6f into develop Jun 24, 2023
@gimhanul gimhanul deleted the set/contribution branch June 24, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gimhanul gimhanul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Contribution
1 participant
@gimhanul