Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card border shows on mobile while scrolling #688

Open
zkat opened this issue Aug 27, 2023 · 3 comments
Open

Card border shows on mobile while scrolling #688

zkat opened this issue Aug 27, 2023 · 3 comments
Assignees
Labels
accessibility features or updates related to accessibility bug Something isn't working design design or branding related polish general quality improvements ux user experience

Comments

@zkat
Copy link
Contributor

zkat commented Aug 27, 2023

We should probably have these work off a hover state instead of whatever they're doing right now (focus?). Idk. It's kinda weird that they sometimes get that border because mobile doesn't really do stuff like that.

@zkat zkat added accessibility features or updates related to accessibility bug Something isn't working design design or branding related ux user experience labels Aug 27, 2023
@rjt-rockx
Copy link
Contributor

It doesn't exactly show up when purely scrolling, it shows up when part of that scroll is long enough to be registered as an individual tap, which then triggers the focus state since that's where the last interaction was.
The ideal way to prevent this would be to delay setting the focus state (probably until the mouseup event) when the pointer type is coarse (i.e. a touch, on mobile devices).

@skullbunnygalaxy
Copy link
Contributor

skullbunnygalaxy commented Aug 28, 2023

I can adjust this using tailwindcss.

@skullbunnygalaxy skullbunnygalaxy self-assigned this Aug 28, 2023
@skullbunnygalaxy
Copy link
Contributor

There was an unfortunate bug when trying to increase the delay setting on the hover state. Instead I have adjusted it so that the hover setting only happens when not on mobile.

@zkat zkat added the polish general quality improvements label Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility features or updates related to accessibility bug Something isn't working design design or branding related polish general quality improvements ux user experience
Projects
Status: 🏗 In progress
Development

No branches or pull requests

3 participants