Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): search (#23) #24

Merged
merged 5 commits into from
May 15, 2024
Merged

feat(common): search (#23) #24

merged 5 commits into from
May 15, 2024

Conversation

kyechan99
Copy link
Member

@kyechan99 kyechan99 commented Apr 24, 2024

common ui

  • search

feature

  • Search
  • SearchInput
  • SearchInputToggle
  • SearchToggle
  • SearchItemList
  • SearchItem
  • SearchLabel
  • SearchDivider

@kyechan99 kyechan99 added the feature New feature or request label Apr 24, 2024
@kyechan99 kyechan99 self-assigned this Apr 24, 2024
Copy link

github-actions bot commented Apr 24, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.13% 2816 / 3514
🔵 Statements 80.13% 2816 / 3514
🔵 Functions 65.3% 64 / 98
🔵 Branches 74.1% 186 / 251
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/index.ts 100% 100% 100% 100%
src/components/Portal/Portal.tsx 75.8% 75% 20% 75.8% 31-37, 40-52, 55-64
src/components/Portal/PortalContent.tsx 96.22% 100% 50% 96.22% 21-22
src/components/Search/Search.tsx 68.42% 100% 0% 68.42% 14-19
src/components/Search/SearchContent.tsx 70% 100% 100% 70% 14-19
src/components/Search/SearchInput.tsx 70.37% 100% 0% 70.37% 9-16
src/components/Search/SearchInputToggle.tsx 25.71% 100% 100% 25.71% 17-68
src/components/Search/SearchItem.tsx 50.9% 100% 100% 50.9% 13-30, 45-53
src/components/Search/SearchToggle.tsx 51.16% 100% 100% 51.16% 21-41
src/components/Search/index.tsx 100% 100% 100% 100%
src/components/Select/SelectItem.tsx 98.91% 91.66% 100% 98.91% 26
Generated in workflow #63

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 60.95238% with 123 lines in your changes are missing coverage. Please review.

Project coverage is 80.15%. Comparing base (f4d045c) to head (cf9911b).

Files Patch % Lines
src/components/Search/SearchInputToggle.tsx 27.14% 51 Missing ⚠️
src/components/Search/SearchItem.tsx 50.90% 27 Missing ⚠️
src/components/Search/SearchToggle.tsx 51.16% 21 Missing ⚠️
src/components/Search/SearchInput.tsx 70.37% 8 Missing ⚠️
src/components/Search/Search.tsx 68.42% 6 Missing ⚠️
src/components/Search/SearchContent.tsx 70.00% 6 Missing ⚠️
src/components/Portal/Portal.tsx 78.94% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   82.02%   80.15%   -1.87%     
==========================================
  Files          75       82       +7     
  Lines        3226     3513     +287     
  Branches      226      226              
==========================================
+ Hits         2646     2816     +170     
- Misses        580      697     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kyechan99 kyechan99 merged commit b7618ef into main May 15, 2024
2 checks passed
@kyechan99 kyechan99 linked an issue Sep 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat: search
2 participants