Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: add MIMA exclusions to by-pass known false-positive #63

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Dec 3, 2019

The build for the versions 5.2.0 has been failing because of a bug case of false positives in MIMA, caused by a bug in the Scala compiler having been fixed between two different versions, as described in lightbend-labs/mima#423.
To silence those false positives, we add exclusion filters.

The build for the versions 5.2.0 has been failing because
of a bug in lightbend-labs/mima#432.
To avoid falling into that bug, we add exclusion filters.
Copy link
Collaborator

@ChristopherDavenport ChristopherDavenport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@diesalbla diesalbla merged commit e9ffef6 into series/5.x Dec 3, 2019
@diesalbla diesalbla deleted the add_mima_falsepositives_exclusions branch December 3, 2019 19:39
@dwijnand
Copy link

dwijnand commented Dec 5, 2019

In my eyes it's not a "bug in MiMa"... It's a bug fix in the compiler that MiMa doesn't have custom logic (i.e. an enhancement, in my eyes).

MiMa's new IncompatibleSignatureProblem-based logic is making an attempt at catching potential issues, but it's not water-tight - in fact, adding exclude[IncompatibleSignatureProblem]("*") can be a reasonable thing to do, to avoid spending time on any noisy false positives.

(Actually... maybe we should change the default behaviour...)

@diesalbla diesalbla changed the title Build: add MIMA exclusions to by-pass known bug Build: add MIMA exclusions to by-pass known false-negative Dec 5, 2019
@diesalbla diesalbla changed the title Build: add MIMA exclusions to by-pass known false-negative Build: add MIMA exclusions to by-pass known false-positive Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants