-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media3 #166
Open
ArchangelWTF
wants to merge
21
commits into
Baseflow:media3
Choose a base branch
from
ArchangelWTF:media3
base: media3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Media3 #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ExoPlayer to 2.19.1
@martijn00 When you have time to look this over can you approve and merge this? |
8 tasks
Hi! Is there a reason why this has not been integrated and released to the nuget package ? |
@Mackly Because it was decided not to be adopted, also Xamarin will have a Media3 package available soon (Went into review this week: xamarin/AndroidX#710) |
Thanks for the reply, I am following closely |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Introduces Media3 (Fixes: #157)
@martijn00 This fully introduces Media3, I've updated the PackageId's as I think it would break to have media3 published on the current ExoPlayer Id's..
As well as that, if you merge this.. Could you set media3 as the main branch for this repository? This will allow us to keep the current develop and exoplayer branches should we need to do anything with them.
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
🐛 Recommendations for testing
📝 Links to relevant issues/docs
🤔 Checklist before submitting