Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose memoryCacheContainsKey method from cache_store #354

Merged

Conversation

vinicius0026
Copy link
Contributor

✨ What kind of change does this PR introduce?

Feature

⤵️ What is the current behavior?

No way of knowing if a key is in the memory cache.

🆕 What is the new behavior (if this is a feature change)?

New method to know if a given key is present in the memory cache

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Unit tests were added - there's not much to test really, it's a really simple new method.

📝 Links to relevant issues/docs

🤔 Checklist before submitting

  • All projects build
  • Follows style guide lines (code style guide)
  • Relevant documentation was updated
  • Rebased onto current develop

@martijn00 martijn00 force-pushed the expose_memory_cache_contains_key branch from a9c370c to 6cd8334 Compare July 31, 2024 18:23
@martijn00 martijn00 merged commit 5345af5 into Baseflow:develop Jul 31, 2024
8 of 9 checks passed
@martijn00 martijn00 mentioned this pull request Aug 1, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants