-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: allow customization of CONFIG_FILE
during install.sh
#2241
Labels
Comments
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
draft to resolve Bash-it#2241 if the code is ok, documentation can be updated in additional commit.
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
- update `install.sh` - update `README.md` Signed-off-by: Max Kovgan <kovganm@gmail.com>
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
- update `install.sh` - update `README.md` Signed-off-by: Max Kovgan <kovganm@gmail.com>
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
- update `install.sh` - update `README.md` Signed-off-by: Max Kovgan <kovganm@gmail.com>
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
- update `install.sh` & `uninstall.sh` - update `README.md` Signed-off-by: Max Kovgan <kovganm@gmail.com>
mvk
added a commit
to mvk/bash-it
that referenced
this issue
Feb 26, 2024
- update `install.sh` & `uninstall.sh` - update `README.md` Signed-off-by: Max Kovgan <kovganm@gmail.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected behavior
as a "deployer" I'd like to be able to override
CONFIG_FILE
so that instead of directly updating~/.bashrc
, another file would be created, and then loaded into~/.bashrc
(or whatever).for example, I'd like to have bash-it config file at
~/.bash.d/scripts/bash-it.bash
, and load it from~/.bashrc
.This "feature" has a side-effect of easily allowing to compare resulting
.bashrc
file with an expected value, thus allowing testing.Current behavior
currently
install.sh
determinesCONFIG_FILE
value based onOSTYPE
at line 188.Possible solution
Introduce an env variable
BASH_IT_CONFIG_FILE
, if defined, setCONFIG_FILE
to its value.Context
currently (the lack of thereof requires me to):
hopefully I'd be able to:
Notes
I can implement the above.
The text was updated successfully, but these errors were encountered: