Lint/vue completions

[tbhaxor]

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• If my change requires a change to the documentation, I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
• [] I have added tests to cover my changes, and all the new and existing tests pass.

[tbhaxor]

@NoahGorny Lint is failing

If am using string in COMPREPLY the completions are breaking

Also I am getting this error on the console after running "./lint_clean_files.sh"

In completion/available/vuejs.completion.bash line 43:
                COMPREPLY=($(compgen -W "-h --help -v --version create add invoke inspect serve build ui init config outdated upgrade migrate info" -- "$curr"))
                           ^-- SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).

Last but not the least the shfmt command is not working properly

[NoahGorny]

I think SC2207 should be addressed, but the shfmt problem is a known one (#652)
I say you should fix the shellcheck error and we will wait for a shfmt cleanup, at the meantime, you can just run shfmt multiple times to get rid of the bug @tbhaxor

[tbhaxor]

I think SC2207 should be addressed, but the shfmt problem is a known one (#652)
I say you should fix the shellcheck error and we will wait for a shfmt cleanup, at the meantime, you can just run shfmt multiple times to get rid of the bug @tbhaxor

Do you have fix for it? When i read with IFS=' ' read -a COMPREPLY < <(compgen -W "..." -- "$curr"), completions are breaking

[NoahGorny]

I think SC2207 should be addressed, but the shfmt problem is a known one (#652)
I say you should fix the shellcheck error and we will wait for a shfmt cleanup, at the meantime, you can just run shfmt multiple times to get rid of the bug @tbhaxor

Do you have fix for it? When i read with IFS=' ' read -a COMPREPLY < <(compgen -W "..." -- "$curr"), completions are breaking

Well @tbhaxor, you are correct. I opened #1791 to ignore this lint error, so just leave the line as it is, and run shfmt a few times

[tbhaxor]

@NoahGorny I tried shfmt for multiple times (~10 times) but nothing is changed. Same formatting with spaces

[NoahGorny]

@NoahGorny I tried shfmt for multiple times (~10 times) but nothing is changed. Same formatting with spaces

Try to update your PR with the latest master, and let me know if there is still a problem like this

[tbhaxor]

@NoahGorny I guess its ready to be merged with master

[NoahGorny]

I have made some changes, mostly moved the shell ignore directive to be under each line that violates it, and remove the uneeded condition. @tbhaxor you are welcome to take a look, nice work 😄