Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion/wpscan: simplify code flow (whitespace) #1961

Merged
merged 1 commit into from
Sep 28, 2021

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 20, 2021

Description

Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review September 22, 2021 21:01
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed mostly just the early bailout, whitespace adjustments.

BUT also fixing array to be an actual array.

cc: @tbhaxor I think you and I broke this in #1898 where $_opt_ became the entire OPTS string ...

I'm going tentatively mark as approved but would like @tbhaxor to chime in before merging ...

@gaelicWizard
Copy link
Contributor Author

I've rebased on current master, and changed " to ' for the $OPTS array.

@davidpfarrell
Copy link
Contributor

davidpfarrell commented Sep 23, 2021

Q: Can we add this to clean_files.txt ?

[edit] Grammar

Convert from indented if-block to return then unindented code. This should have basically one line change at the top, one line removed at the bottom, and then all whitespace.
@gaelicWizard
Copy link
Contributor Author

gaelicWizard commented Sep 23, 2021

Q: Can we add this to clean_files.txt ?

Already is! 👍

@NoahGorny NoahGorny merged commit 002a23c into Bash-it:master Sep 28, 2021
@gaelicWizard gaelicWizard deleted the completion-wpscan branch September 29, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants