Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

completion/git: improvements and linting #1965

Merged
merged 2 commits into from
Oct 6, 2021
Merged

completion/git: improvements and linting #1965

merged 2 commits into from
Oct 6, 2021

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Sep 25, 2021 •
edited
Loading

Description

Update to not be Mac-specific, alsö update the Mac-specific logic, and add to clean_files.txt.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard
completion/git: expand search range
e22aac8 
- Remove limitation on OS.
- Add search for Mac OS X developer tools locations by using `xcrun` instead of trying to guess paths.
- �Add search for locations based on path of `$GIT_EXE` (set by `lib/theme`).
@gaelicWizard
completion/git: shfmt && shellcheck
b0750fa
NoahGorny
NoahGorny approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@NoahGorny NoahGorny merged commit cf08fca into Bash-it:master Oct 6, 2021
@gaelicWizard gaelicWizard deleted the completion-git branch October 12, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny