Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wholesale cleanup of all history plugins #1982

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Wholesale cleanup of all history plugins #1982

merged 2 commits into from
Dec 2, 2021

Conversation

cornfeedhobo
Copy link
Member

Description

  • remove the use of redundant cite
  • minor cleanups to history.plugin.bash
  • set explicit load orders for history-search and history-substring-search
  • add new plugin history-eternal

Motivation and Context

history plugins needed some love now that we have dealt with preexec

How Has This Been Tested?

locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@cornfeedhobo
Copy link
Member Author

@NoahGorny I have absolutely no idea why doc generation is failing. Could you take a look? Thanks!

@NoahGorny
Copy link
Member

hi @cornfeedhobo, I filed #1984 to fix this failure 😃

@cornfeedhobo
Copy link
Member Author

@NoahGorny @gaelicWizard alright, have a look

NoahGorny
NoahGorny approved these changes Nov 20, 2021
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

@tsiflimagas
Copy link
Contributor

tsiflimagas commented Nov 24, 2021 •
edited
Loading

Shouldn't that if statement be kept in the history plugin to restore HISTTIMEFORMAT, if it is set?

@cornfeedhobo
Copy link
Member Author

cornfeedhobo commented Nov 26, 2021 •
edited
Loading

@tsiflimagas great catch!
@NoahGorny Sorry I'll need one more here. Thanks in advance. Looks like I can still merge and there is not a significant change here. Moving forward 😄

@cornfeedhobo
Wholesale cleanup of all history plugins
bdb5289 
- remove the use of redundant cite
- minor cleanups to history.plugin.bash
- set explicit load orders for history-search and history-substring-search
- add new plugin history-eternal
- replace superfluous trap for managing HISTTIMEFORMAT changes
@cornfeedhobo
Fix linting errors that snuck in.
2c8ee40
@cornfeedhobo cornfeedhobo merged commit 1882f50 into Bash-it:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cornfeedhobo @NoahGorny @tsiflimagas