Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/dirs: use $XDG_STATE_HOME #2001

Merged
merged 3 commits into from
Jan 7, 2022
Merged

Plugin/dirs: use $XDG_STATE_HOME #2001

merged 3 commits into from
Jan 7, 2022

Conversation

gaelicWizard
Copy link
Contributor

@gaelicWizard gaelicWizard commented Dec 28, 2021 •
edited
Loading

Please review commit notes as appropriate.

Description

Use $XDG_STATE_HOME, and alsö run shfmt and shellcheck and all that jazz.

Motivation and Context

Just cleaning up!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review December 28, 2021 01:26
@gaelicWizard gaelicWizard force-pushed the plugin-dirs branch 2 times, most recently from 5ceea60 to 2d22655 Compare December 31, 2021 08:13
@gaelicWizard
plugins/dirs: use XDG_STATE_HOME
d8e7b17 
Locate the bookmarks file in $XDG_STATE_HOME, and migrate an existing file from the old location if it exists.
@gaelicWizard
plugin/dirs: shfmt && shellcheck
71b4f3c
@gaelicWizard
plugin/dirs: use $BASH_IT_DIRS_BKS.new instead of ~/.dirs1
8b308df
NoahGorny
NoahGorny approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that we keep backwards compatiblity

@NoahGorny NoahGorny merged commit c060eb4 into Bash-it:master Jan 7, 2022
@gaelicWizard gaelicWizard deleted the plugin-dirs branch January 7, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny