Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update variable name to match projects.plugin.bash #2161

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

brianphillips
Copy link
Contributor

Description

The projects plugin was changed to reference BASH_IT_PROJECT_PATHS but the completion was still using PROJECT_PATHS

Motivation and Context

This fixes a regression in the project completion code due to a refactor in the project plugin code

How Has This Been Tested?

Tested locally

Screenshots (if appropriate):

n/a

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

The projects plugin was changed to reference `BASH_IT_PROJECT_PATHS` but the completion was still using `PROJECT_PATHS`
Copy link
Contributor

@davidpfarrell davidpfarrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best I can tell this looks legit and a good catch !

@brianphillips
Copy link
Contributor Author

@davidpfarrell What's the next step here?

@davidpfarrell
Copy link
Contributor

@davidpfarrell What's the next step here?

We're waiting for those who do the merges to find time in their busy lives to review the approved PRs and (hopefully) merge them or comment if they need any changes / clarifications / etc.

@NoahGorny NoahGorny merged commit 8bedbe4 into Bash-it:master Sep 13, 2022
@NoahGorny
Copy link
Member

Thanks @brianphillips
@davidpfarrell you can always merge if you feel comfortable:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants