-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reproduce DR learner notebook using chirho.robust
#474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This notebook could certainly use some more text, but I think we can add that in a subsequent PR.
See my comment about the outline for an easy to address issue that should be fixed before the PR lands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the outline is taken from the backdoor adjustment tutorial, and doesn't align with this notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the outlines are wrong or at least have broken links in a number of other tutorials, which suggests the manually written outlines may be too brittle to bother maintaining when Sphinx, JupyterLab, VSCode and most other editors already generate and render outlines automatically from the section headers. I just removed it from this one entirely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. We can follow up in a separate PR to make all the outlines consistent with whatever we decide.
This PR closes #373