Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce DR learner notebook using chirho.robust #474

Merged
merged 88 commits into from
Jul 18, 2024
Merged

Conversation

agrawalraj
Copy link
Contributor

@agrawalraj agrawalraj commented Jan 3, 2024

This PR closes #373

@eb8680 eb8680 removed status:WIP Work-in-progress not yet ready for review blocked labels Jul 10, 2024
@eb8680 eb8680 requested a review from azane July 10, 2024 16:41
@eb8680 eb8680 added the status:awaiting review Awaiting response from reviewer label Jul 10, 2024
@eb8680 eb8680 self-assigned this Jul 10, 2024
@eb8680 eb8680 added examples and removed enhancement New feature or request labels Jul 10, 2024
@eb8680 eb8680 requested a review from SamWitty July 10, 2024 18:27
Copy link
Collaborator

@SamWitty SamWitty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This notebook could certainly use some more text, but I think we can add that in a subsequent PR.

See my comment about the outline for an easy to address issue that should be fixed before the PR lands.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the outline is taken from the backdoor adjustment tutorial, and doesn't align with this notebook.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the outlines are wrong or at least have broken links in a number of other tutorials, which suggests the manually written outlines may be too brittle to bother maintaining when Sphinx, JupyterLab, VSCode and most other editors already generate and render outlines automatically from the section headers. I just removed it from this one entirely.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. We can follow up in a separate PR to make all the outlines consistent with whatever we decide.

@SamWitty SamWitty added status:awaiting response Awaiting response from creator and removed status:awaiting review Awaiting response from reviewer labels Jul 16, 2024
@eb8680 eb8680 requested a review from SamWitty July 18, 2024 00:39
@eb8680 eb8680 added status:awaiting review Awaiting response from reviewer and removed status:awaiting response Awaiting response from creator labels Jul 18, 2024
@SamWitty SamWitty merged commit 11c5ad5 into master Jul 18, 2024
7 checks passed
@SamWitty SamWitty deleted the ra-dr-notebook2 branch July 18, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples module:robust status:awaiting review Awaiting response from reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redo DR-learner example using our new interface
3 participants