Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename cv_voltage_thresh and its location in config #40

Merged

Conversation

eravet
Copy link
Contributor

@eravet eravet commented May 2, 2023

No description provided.

@eravet eravet linked an issue May 2, 2023 that may be closed by this pull request
@eravet eravet temporarily deployed to Actions May 2, 2023 22:09 — with GitHub Actions Inactive
@eravet eravet temporarily deployed to Actions May 2, 2023 22:09 — with GitHub Actions Inactive
Copy link
Collaborator

@chintanp chintanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@SyXuan SyXuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for finding this!

@SyXuan SyXuan merged commit 8ab0880 into main May 3, 2023
@SyXuan SyXuan deleted the 38-bug-cycle-stats-fails-to-run-with-cv_voltage_threshold_mv branch May 3, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] cycle stats fails to run with cv_voltage_threshold_mv
3 participants