Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes for the preprocessing steps #142

Merged
merged 4 commits into from
Jul 21, 2020
Merged

Conversation

smmaurer
Copy link

This PR fixes two bugs that were preventing the preprocessing steps from running (i.e. python baus.py --mode preprocessing).

  1. There were a couple of places where the settings injectable needed to be updated to mappings, to reflect a change in yaml files from a few months ago.

  2. Due to changes in the base data, I had to loosen a requirement in the allocate_jobs() helper function that's used in the preproc_jobs step.

    The baseyear_taz_controls.csv file lists job counts for each TAZ, which are allocated to specific buildings using this code. If there are jobs but no buildings for a particular TAZ, allocate_jobs() raises an error and crashes.

    This is now happening for a couple of TAZ's. I modified the code to log the problem and move on, which lets the remainder of the preprocessing complete. The mismatches will need to be resolved on the data side (see separate discussion in Slack).

Testing

With these changes, preprocessing runs successfully on my machine (Mac, Python 3.6) using a clean copy of the repo and base data. Output in the log looks reasonable, aside from the problem allocating jobs that's noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants