Revise the exporters API #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krinart
requested changes
Jan 31, 2019
m2cgen/exporters.py
Outdated
| return assembler_cls | ||
| def _export(model, interpreter): | ||
| model_name = type(model).__name__ | ||
| assembler_cls = _get_assembler_cls(model_name) |
There was a problem hiding this comment.
I know it's probably my code, but maybe move logic of building model_name into _get_assembler_cls function?
| @@ -45,9 +45,7 @@ def interpret(self, expr): | |||
| os.path.dirname(__file__), "linear_algebra.java") | |||
| top_cg.add_code_lines(utils.get_file_content(filename)) | |||
|
|
|||
| return [ | |||
| (self.model_name, top_cg.code), | |||
| ] | |||
tests/e2e/executors/java.py
Outdated
| for model_name, code in self.exporter.export(): | ||
| file_name = os.path.join(self._resource_tmp_dir, | ||
| "{}.java".format(model_name)) | ||
| model_name = "Model" |
There was a problem hiding this comment.
Maybe move it to the class level and reuse in predict() method?
krinart
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.