Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding syntax support for externally defined distributions and functions #307

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lileicc
Copy link
Contributor

@lileicc lileicc commented Sep 24, 2014

@cberzan @jxwuyi @datang1992 @tejasvsrinivasan

distribution Real Gaussian(Real mu, Real variance);
extern Real abs(Real x);

@lileicc
Copy link
Contributor Author

lileicc commented Sep 24, 2014

@cberzan
would you please check why it fails the test?

@lileicc
Copy link
Contributor Author

lileicc commented Sep 24, 2014

solved compilation issue.

@lileicc
Copy link
Contributor Author

lileicc commented Sep 27, 2014

I have another thought about extern.

extern might not be necessary. Since we can already write,

fixed Real abs(Real abs) = blog.model.AbsInterp();

Or we should even simplify it to be

fixed Real abs(Real abs) = blog.model.AbsInterp;

@lileicc
Copy link
Contributor Author

lileicc commented Sep 29, 2014

extern Real abs(Real x);
distribution Real Gaussian(Real mu, Real variance);

@cberzan
Copy link
Contributor

cberzan commented Oct 2, 2014

@lileicc Are you still changing this, or should I review?

@lileicc
Copy link
Contributor Author

lileicc commented Oct 2, 2014

This is not ready for review yet. Since it needs support in Semant.java.

On Wed, Oct 1, 2014 at 5:24 PM, cberzan notifications@github.com wrote:

@lileicc https://github.com/lileicc Are you still changing this, or
should I review?


Reply to this email directly or view it on GitHub
#307 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants