Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disables macro-clicking real good. #16444

Merged
merged 1 commit into from
Feb 28, 2017

Conversation

PsiOmegaDelta
Copy link
Member

@PsiOmegaDelta PsiOmegaDelta commented Feb 28, 2017

http://www.byond.com/forum/?post=2219001 provided more information than the original source.

http://www.byond.com/docs/ref/info.html#/client/var/control_freak should be reviewed for the consequences of setting the control_freak var.

http://www.byond.com/forum/?post=2219001 provided more information than the original source.
@comma
Copy link
Contributor

comma commented Feb 28, 2017

This seems to disable ALL client macroes, not just clicking, as per control freak setting

@PsiOmegaDelta
Copy link
Member Author

PsiOmegaDelta commented Feb 28, 2017

The flags function a bit weirdly:
If CONTROL_FREAK_ALL is used, then the other flags re-enable their respective features.
If CONTROL_FREAK_ALL isn't used, then the other flags disable their features.
See near the bottom of the linked reference.

However, based on the linked BYOND discussion this won't re-enable quite everything and (macro?) commands can no longer be entered directly. Have to admit I'm not fully certain why it's necessary.

@comma comma merged commit e5b8207 into Baystation12:dev Feb 28, 2017
@PsiOmegaDelta PsiOmegaDelta deleted the 170228-BreakItharder branch February 28, 2017 13:15
@skull132
Copy link
Contributor

@PsiOmegaDelta Stumbled across a potential exploit enabled by this PR while it was discussed in host chat.

Logging the use of these and broadcasting it to admins makes it possible for someone to create a macro of nothing but .click\n and to effectively freeze up, if not crash the staff online at the time with a massive amount of logs. Unless you modified your message_admins to check for that, but I failed to find any evidence for that. I do believe the notifications for failed login attempt got silenced for the same reason.

@Iamgoofball
Copy link
Contributor

or I just open Razer synapse and bind macro1 to no delay click

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants