Attempt at a complete MVP domain model for survey planning #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… surveys by Marina - unfortunately causes additional planner flakiness
|
@trey0 You mentioned having @Abster101 take a look at this, do you still want to wait for him to take a look before we merge this? |
Let's go ahead and merge to unblock @marinagmoreira . We can always iterate if @Abster101 has feedback later. |
|
Done, and I opened up a PR with his version for comparison: #2 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filing this PR so Abiola can review and we can all discuss.
Abiola's previous domain model seemed to be more like an outline of a domain model than an attempt at a complete model. It also started to sketch out some nice-to-have features that I think we won't be able to deliver (at least in time for ISAAC-13).
I decided to take a swing at some improvements. This version tries to be a complete model and prunes out the nice-to-have stuff. It presumably still has some bugs. I'm a PDDL novice.
Update Fri Oct 27: Got this mostly working under
popf. Seesample_output_plan.txtfor example usage and results with timing. Using thepopfversion found here.